test: add missing test coverage for stats/incr/nanwmean by KovidhRaj · Pull Request #9945 · stdlib-js/stdlib

KovidhRaj · 2026-01-28T11:51:32Z

Resolves #{{TODO: add issue number}}.

Description

This PR adds missing unit test coverage for @stdlib/stats/incr/nanwmean,
mirroring the behavioral guarantees of wmean with appropriate adaptations
for NaN-skipping behavior.

No changes to implementation logic are included.

Related to #6441.

What is the purpose of this pull request?

This pull request:

adds missing unit test coverage for @stdlib/stats/incr/nanwmean,
mirroring the behavioral guarantees of wmean with appropriate adaptations for
NaN-skipping behavior. No changes to implementation logic are included.

This work helps complete the existing nanwmean implementation proposed in #6441.

{{TODO: add description describing what this pull request does}}

Related Issues

Does this pull request have any related issues?

This pull request has the following related issues:

#{{TODO: add related issue number}}

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

Read, understood, and followed the contributing guidelines.

AI Assistance

When authoring the changes proposed in this PR, did you use any kind of AI assistance?

Yes
No

If you answered "yes" above, how did you use AI assistance?

Code generation (e.g., when writing an implementation or fixing a bug)
Test/benchmark generation
Documentation (including examples)
Research and understanding

Disclosure

If you answered "yes" to using AI assistance, please provide a short disclosure indicating how you used AI assistance. This helps reviewers determine how much scrutiny to apply when reviewing your contribution. Example disclosures: "This PR was written primarily by Claude Code." or "I consulted ChatGPT to understand the codebase, but the proposed changes were fully authored manually by myself.".

@stdlib-js/reviewers

… namespace This commit adds a package which provides a way to compute the mean of a set of numbers while ignoring NaN values. It is made to address [RFC] Issue stdlib-js#5628, and as suggested in the issue, it is based on a thin wrapper around wmean, similar to the relationship between nansum and sum, mainting API consistency and design. This commit includes appropriate documentation and tests for the new purpose of the package, styles of which are consistent to the stats/incr/* namespace. Fixes: stdlib-js#5628 [RFC] Private-ref: stdlib-js#5628 Authored-by: Don Chacko <donisepic30@gmail.com>

… stats/incr/* namespace This commit adds minor changes to the README.md of the nanwmean package, to improve clarity and fix a mistake in the usage section where a different package was used. Author: Don Roy Chacko <donisepic30@gmail.com> Reviewed-by: hrshya Co-authored-by: Harsh <149176984+hrshya@users.noreply.github.com> Signed-off-by: Don Roy Chacko <52739172+SergeantQuickscoper@users.noreply.github.com>

This commit fixes the lint errors in the nanwmean module. The changes are applied to the following files: - nanwmean/README.md - nanwmean/docs/repl.txt - nanwmean/lib/index.js - nanwmean/lib/main.js - nanwmean/test/test.js Improvements include: - Correcting indentation and spacing issues - Switch to LF line endings

This commit fixes remark lint errors in the README.md file for the `@stdlib/stats/incr/nanwmean` package. Authored By: Don Roy Chacko <donisepic30@gmail.com>

This commit is a license header lint fix for the nanwmean module for the README.md file.

…lib into feature/nanwmean This commit accounts for the merge of the lint_autofix commit to the feature/nanwmean branch.

--- type: pre_commit_static_analysis_report description: Results of running static analysis checks when committing changes. report: - task: lint_filenames status: passed - task: lint_editorconfig status: passed - task: lint_markdown status: na - task: lint_package_json status: na - task: lint_repl_help status: na - task: lint_javascript_src status: na - task: lint_javascript_cli status: na - task: lint_javascript_examples status: na - task: lint_javascript_tests status: passed - task: lint_javascript_benchmarks status: na - task: lint_python status: na - task: lint_r status: na - task: lint_c_src status: na - task: lint_c_examples status: na - task: lint_c_benchmarks status: na - task: lint_c_tests_fixtures status: na - task: lint_shell status: na - task: lint_typescript_declarations status: passed - task: lint_typescript_tests status: na - task: lint_license_headers status: passed ---

stdlib-bot · 2026-01-28T11:51:42Z

Hello! Thank you for your contribution to stdlib.

We noticed that the contributing guidelines acknowledgment is missing from your pull request. Here's what you need to do:

Please read our contributing guidelines.
Update your pull request description to include this checked box:

- [x] Read, understood, and followed the [contributing guidelines](https://github.com/stdlib-js/stdlib/blob/develop/CONTRIBUTING.md)

This acknowledgment confirms that you've read the guidelines, which include:

The developer's certificate of origin
Your agreement to license your contributions under the project's terms

We can't review or accept contributions without this acknowledgment.

Thank you for your understanding and cooperation. We look forward to reviewing your contribution!

KovidhRaj · 2026-01-28T11:52:28Z

I’ve added missing test coverage for nanwmean in a follow-up PR
to help complete the original implementation.

stdlib-bot · 2026-01-28T11:53:46Z

Coverage Report

Package	Statements	Branches	Functions	Lines
stats/incr/nanwmean	$\color{green}129/129$ $\color{green}+0.00%$	$\color{green}8/8$ $\color{green}+0.00%$	$\color{green}2/2$ $\color{green}+0.00%$	$\color{green}129/129$ $\color{green}+0.00%$

The above coverage report was generated for the changes in this PR.

--- type: pre_commit_static_analysis_report description: Results of running static analysis checks when committing changes. report: - task: lint_filenames status: passed - task: lint_editorconfig status: passed - task: lint_markdown status: passed - task: lint_package_json status: na - task: lint_repl_help status: na - task: lint_javascript_src status: passed - task: lint_javascript_cli status: na - task: lint_javascript_examples status: passed - task: lint_javascript_tests status: passed - task: lint_javascript_benchmarks status: passed - task: lint_python status: na - task: lint_r status: na - task: lint_c_src status: na - task: lint_c_examples status: na - task: lint_c_benchmarks status: na - task: lint_c_tests_fixtures status: na - task: lint_shell status: na - task: lint_typescript_declarations status: passed - task: lint_typescript_tests status: passed - task: lint_license_headers status: passed ---

--- type: pre_commit_static_analysis_report description: Results of running static analysis checks when committing changes. report: - task: lint_filenames status: passed - task: lint_editorconfig status: passed - task: lint_markdown status: na - task: lint_package_json status: na - task: lint_repl_help status: na - task: lint_javascript_src status: na - task: lint_javascript_cli status: na - task: lint_javascript_examples status: na - task: lint_javascript_tests status: na - task: lint_javascript_benchmarks status: na - task: lint_python status: na - task: lint_r status: na - task: lint_c_src status: na - task: lint_c_examples status: na - task: lint_c_benchmarks status: na - task: lint_c_tests_fixtures status: na - task: lint_shell status: na - task: lint_typescript_declarations status: passed - task: lint_typescript_tests status: passed - task: lint_license_headers status: passed ---

Planeshifter

Thanks for opening a PR!

Planeshifter · 2026-03-09T05:46:08Z

+
+tape( 'the initial accumulated value is `null`', function test( t ) {
+	var acc = incrnanwmean();
+	t.equal( acc(), null, 'returns expected value' );


Use t.strictEqual instead of t.equal here (and on lines 107, 118, 126, 136). We use t.strictEqual throughout the project for equality checks.

Suggested change

t.equal( acc(), null, 'returns expected value' );

t.strictEqual( acc(), null, 'returns expected value' );

Planeshifter · 2026-03-09T05:46:11Z

+	var acc = incrnanwmean();
+
+	acc( 2.0, 1.0 );
+	t.strictEqual( isnan(acc( 3.0 )), true, 'returns current mean when weight is missing' );


Missing space inside parens. Should be isnan( acc( 3.0 ) ).

Suggested change

t.strictEqual( isnan(acc( 3.0 )), true, 'returns current mean when weight is missing' );

t.strictEqual( isnan( acc( 3.0 ) ), true, 'returns current mean when weight is missing' );

Planeshifter · 2026-03-09T05:46:13Z

+	acc( NaN, 1.0 );
+	acc( 4.0, 1.0 );
+
+	t.equal( acc(), 3.0, 'NaN does not posion accumulator state' );


Typo: "posion" → "poison".

Suggested change

t.equal( acc(), 3.0, 'NaN does not posion accumulator state' );

t.strictEqual( acc(), 3.0, 'NaN does not poison accumulator state' );

Planeshifter · 2026-03-09T05:46:17Z

+	acc( 2.0, 1.0);
+	acc( NaN, 1.0);


Missing spaces before closing parens on these two lines, and var declarations need to be at the top of the function scope (before acc( 2.0, 1.0 )). Move var v1; and var v2; above the acc(...) calls.

Suggested change

acc( 2.0, 1.0);

acc( NaN, 1.0);

acc( 2.0, 1.0 );

acc( NaN, 1.0 );

Planeshifter · 2026-03-09T05:46:19Z

+	t.equal( acc(), 2.0, 'ignores invalid inputs and maintains correct mean' );
+	t.end();
+});
+tape( 'if not provided a weight, the accumulator function returns NaN', function test( t ) {


Need a blank line between tape blocks throughout the file (missing here and before lines 147 and 157). Each tape(...) call should be separated by a blank line from the preceding block's closing });.

Planeshifter · 2026-03-09T05:46:22Z

@@ -0,0 +1,41 @@
+{{alias}}()


Missing leading blank line. repl.txt files should start with an empty line before {{alias}}. Also, the parameter block (lines 12-15) doesn't follow the standard format. Compare against incrwmean's repl.txt for the expected structure.

KovidhRaj · 2026-03-30T16:43:13Z

okay will do the required changes and fix it.

SergeantQuickscoper and others added 10 commits March 30, 2025 01:30

Merge branch 'stdlib-js:develop' into feature/nanwmean

d8df986

fixup! feat (stats/incr/nanwmean): fixes remark lint errors

cb7d379

This commit fixes remark lint errors in the README.md file for the `@stdlib/stats/incr/nanwmean` package. Authored By: Don Roy Chacko <donisepic30@gmail.com>

Merge branch 'stdlib-js:develop' into feature/nanwmean

d7b1d7b

fix: resolve lint errors

a2378d0

fixup! feat (stats/incr/nanwmean): fix final license header lint

896bbf3

This commit is a license header lint fix for the nanwmean module for the README.md file.

Merge branch 'feature/nanwmean' of github.com:SergeantQuickscoper/std…

c27d2c8

…lib into feature/nanwmean This commit accounts for the merge of the lint_autofix commit to the feature/nanwmean branch.

stdlib-bot added Statistics Issue or pull request related to statistical functionality. Needs Review A pull request which needs code review. labels Jan 28, 2026

KovidhRaj added 2 commits January 28, 2026 17:37

Planeshifter requested changes Mar 9, 2026

View reviewed changes

Planeshifter added Needs Changes Pull request which needs changes before being merged. and removed Needs Review A pull request which needs code review. labels Mar 9, 2026

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

test: add missing test coverage for stats/incr/nanwmean#9945

test: add missing test coverage for stats/incr/nanwmean#9945
KovidhRaj wants to merge 12 commits intostdlib-js:developfrom
KovidhRaj:test/nanwmean

KovidhRaj commented Jan 28, 2026 •

edited

Loading

Uh oh!

stdlib-bot commented Jan 28, 2026

Uh oh!

KovidhRaj commented Jan 28, 2026

Uh oh!

stdlib-bot commented Jan 28, 2026 •

edited

Loading

Uh oh!

Planeshifter left a comment

Uh oh!

Planeshifter Mar 9, 2026

Uh oh!

Planeshifter Mar 9, 2026

Uh oh!

Planeshifter Mar 9, 2026

Uh oh!

Planeshifter Mar 9, 2026

Uh oh!

Planeshifter Mar 9, 2026

Uh oh!

Planeshifter Mar 9, 2026

Uh oh!

KovidhRaj commented Mar 30, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

	t.equal( acc(), null, 'returns expected value' );
	t.strictEqual( acc(), null, 'returns expected value' );

	t.strictEqual( isnan(acc( 3.0 )), true, 'returns current mean when weight is missing' );
	t.strictEqual( isnan( acc( 3.0 ) ), true, 'returns current mean when weight is missing' );

	t.equal( acc(), 3.0, 'NaN does not posion accumulator state' );
	t.strictEqual( acc(), 3.0, 'NaN does not poison accumulator state' );

Uh oh!

Conversation

KovidhRaj commented Jan 28, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Related Issues

Questions

Other

Checklist

AI Assistance

Disclosure

Uh oh!

stdlib-bot commented Jan 28, 2026

Uh oh!

KovidhRaj commented Jan 28, 2026

Uh oh!

stdlib-bot commented Jan 28, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Coverage Report

Uh oh!

Planeshifter left a comment

Choose a reason for hiding this comment

Uh oh!

Planeshifter Mar 9, 2026

Choose a reason for hiding this comment

Uh oh!

Planeshifter Mar 9, 2026

Choose a reason for hiding this comment

Uh oh!

Planeshifter Mar 9, 2026

Choose a reason for hiding this comment

Uh oh!

Planeshifter Mar 9, 2026

Choose a reason for hiding this comment

Uh oh!

Planeshifter Mar 9, 2026

Choose a reason for hiding this comment

Uh oh!

Planeshifter Mar 9, 2026

Choose a reason for hiding this comment

Uh oh!

KovidhRaj commented Mar 30, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

KovidhRaj commented Jan 28, 2026 •

edited

Loading

stdlib-bot commented Jan 28, 2026 •

edited

Loading